Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flyte remote bugs #737

Merged
merged 2 commits into from
Nov 4, 2021
Merged

fix flyte remote bugs #737

merged 2 commits into from
Nov 4, 2021

Conversation

cosmicBboy
Copy link
Contributor

Signed-off-by: Niels Bantilan [email protected]

TL;DR

Fix FlyteRemote bugs:

  • don't override _closure property with self._closure = None in FlyteWorkflowExecution.__init__
  • Remove unnecessary check in sync_workflow_execution for ResourceType.WORKFLOW

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #737 (46e4b5d) into master (673e076) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #737   +/-   ##
=======================================
  Coverage   85.74%   85.75%           
=======================================
  Files         362      362           
  Lines       29996    29994    -2     
  Branches     2444     2443    -1     
=======================================
  Hits        25721    25721           
+ Misses       3632     3631    -1     
+ Partials      643      642    -1     
Impacted Files Coverage Δ
flytekit/remote/workflow_execution.py 88.88% <ø> (-0.31%) ⬇️
flytekit/remote/remote.py 70.13% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673e076...46e4b5d. Read the comment docs.

@cosmicBboy cosmicBboy merged commit 17201ce into master Nov 4, 2021
@cosmicBboy cosmicBboy deleted the flyte-remote-bugs branch November 4, 2021 20:41
reverson pushed a commit to reverson/flytekit that referenced this pull request May 27, 2022
* fix flyte remote bugs

Signed-off-by: Niels Bantilan <[email protected]>

* fetch workflow id

Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Robert Everson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants