Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flyte remote bugs #737

Merged
merged 2 commits into from
Nov 4, 2021
Merged

fix flyte remote bugs #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8b660b
fix flyte remote bugs
cosmicBboy Nov 2, 2021
46e4b5d
fetch workflow id
cosmicBboy Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions flytekit/remote/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,12 +1030,9 @@ def sync_workflow_execution(
lp_id = execution.spec.launch_plan
if execution.spec.launch_plan.resource_type == ResourceType.TASK:
flyte_entity = self.fetch_task(lp_id.project, lp_id.domain, lp_id.name, lp_id.version)
elif execution.spec.launch_plan.resource_type in {ResourceType.WORKFLOW, ResourceType.LAUNCH_PLAN}:
flyte_entity = self.fetch_workflow(lp_id.project, lp_id.domain, lp_id.name, lp_id.version)
else:
raise user_exceptions.FlyteAssertion(
f"Resource type {execution.spec.launch_plan.resource_type} not recognized. Must be a TASK or WORKFLOW."
)
wf_id = self.fetch_launch_plan(lp_id.project, lp_id.domain, lp_id.name, lp_id.version).workflow_id
flyte_entity = self.fetch_workflow(wf_id.project, wf_id.domain, wf_id.name, wf_id.version)

# sync closure, node executions, and inputs/outputs
execution._closure = self.client.get_execution(execution.id).closure
Expand Down
1 change: 0 additions & 1 deletion flytekit/remote/workflow_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ def __init__(self, *args, **kwargs):
self._node_executions = None
self._inputs = None
self._outputs = None
self._closure = None

@property
def node_executions(self) -> Dict[str, _nodes.FlyteNodeExecution]:
Expand Down