Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyflyte run use config path from arg value #996

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented May 11, 2022

Signed-off-by: Kevin Su [email protected]

TL;DR

pyflyte run should use config path from arg value

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#2474

Follow-up issue

NA

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #996 (642003c) into master (c011ef7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   86.29%   86.29%           
=======================================
  Files         255      255           
  Lines       24284    24285    +1     
  Branches     2768     2768           
=======================================
+ Hits        20955    20956    +1     
  Misses       2856     2856           
  Partials      473      473           
Impacted Files Coverage Δ
flytekit/clis/sdk_in_container/run.py 70.30% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c011ef7...642003c. Read the comment docs.

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor merged commit 9f08c9e into master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants