Strip Type Metadata (#442)

* Strip Type Metadata Signed-off-by: Haytham Abuelfutuh <[email protected]> * Strip variable descriptions Signed-off-by: Haytham Abuelfutuh <[email protected]> * Strip Description Signed-off-by: Haytham Abuelfutuh <[email protected]> * Use a fixed time for datetime field literals Signed-off-by: Haytham Abuelfutuh <[email protected]> * Move logic to strip metadata to k8s transformer Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update code documentation Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Comments Signed-off-by: Haytham Abuelfutuh <[email protected]>
flyteorg · May 24, 2022 · 755e90a · 755e90a
1 parent 24e93cd
commit 755e90a
Show file tree

Hide file tree

Showing 630 changed files with 36,318 additions and 339 deletions.
diff --git a/pkg/compiler/requirements.go b/pkg/compiler/requirements.go
@@ -9,24 +9,24 @@ import (
 type TaskIdentifier = common.Identifier
 type LaunchPlanRefIdentifier = common.Identifier
 
-// Represents the set of required resources for a given Workflow's execution. All of the resources should be loaded before
-// hand and passed to the compiler.
+// WorkflowExecutionRequirements represents the set of required resources for a given Workflow's execution. All the
+// resources should be loaded beforehand and passed to the compiler.
 type WorkflowExecutionRequirements struct {
 	taskIds       []TaskIdentifier
 	launchPlanIds []LaunchPlanRefIdentifier
 }
 
-// Gets a slice of required Task ids to load.
+// GetRequiredTaskIds gets a slice of required Task ids to load.
 func (g WorkflowExecutionRequirements) GetRequiredTaskIds() []TaskIdentifier {
 	return g.taskIds
 }
 
-// Gets a slice of required Workflow ids to load.
+// GetRequiredLaunchPlanIds gets a slice of required Workflow ids to load.
 func (g WorkflowExecutionRequirements) GetRequiredLaunchPlanIds() []LaunchPlanRefIdentifier {
 	return g.launchPlanIds
 }
 
-// Computes requirements for a given Workflow.
+// GetRequirements computes requirements for a given Workflow.
 func GetRequirements(fg *core.WorkflowTemplate, subWfs []*core.WorkflowTemplate) (reqs WorkflowExecutionRequirements, err error) {
 	errs := errors.NewCompileErrors()
 	compiledSubWfs := toCompiledWorkflows(subWfs...)

diff --git a/pkg/compiler/task_compiler.go b/pkg/compiler/task_compiler.go
@@ -107,7 +107,7 @@ func compileTaskInternal(task *core.TaskTemplate, errs errors.CompileErrors) com
 	return taskBuilder{flyteTask: task}
 }
 
-// Task compiler compiles a given Task into an executable Task. It validates all required parameters and ensures a Task
+// CompileTask compiles a given Task into an executable Task. It validates all required parameters and ensures a Task
 // is well-formed.
 func CompileTask(task *core.TaskTemplate) (*core.CompiledTask, error) {
 	errs := errors.NewCompileErrors()