Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Strip Type Metadata #442

Merged
merged 7 commits into from
May 24, 2022
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 5 additions & 5 deletions pkg/compiler/requirements.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,24 @@ import (
type TaskIdentifier = common.Identifier
type LaunchPlanRefIdentifier = common.Identifier

// Represents the set of required resources for a given Workflow's execution. All of the resources should be loaded before
// hand and passed to the compiler.
// WorkflowExecutionRequirements represents the set of required resources for a given Workflow's execution. All the
// resources should be loaded beforehand and passed to the compiler.
type WorkflowExecutionRequirements struct {
taskIds []TaskIdentifier
launchPlanIds []LaunchPlanRefIdentifier
}

// Gets a slice of required Task ids to load.
// GetRequiredTaskIds gets a slice of required Task ids to load.
func (g WorkflowExecutionRequirements) GetRequiredTaskIds() []TaskIdentifier {
return g.taskIds
}

// Gets a slice of required Workflow ids to load.
// GetRequiredLaunchPlanIds gets a slice of required Workflow ids to load.
func (g WorkflowExecutionRequirements) GetRequiredLaunchPlanIds() []LaunchPlanRefIdentifier {
return g.launchPlanIds
}

// Computes requirements for a given Workflow.
// GetRequirements computes requirements for a given Workflow.
func GetRequirements(fg *core.WorkflowTemplate, subWfs []*core.WorkflowTemplate) (reqs WorkflowExecutionRequirements, err error) {
errs := errors.NewCompileErrors()
compiledSubWfs := toCompiledWorkflows(subWfs...)
Expand Down
2 changes: 1 addition & 1 deletion pkg/compiler/task_compiler.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func compileTaskInternal(task *core.TaskTemplate, errs errors.CompileErrors) com
return taskBuilder{flyteTask: task}
}

// Task compiler compiles a given Task into an executable Task. It validates all required parameters and ensures a Task
// CompileTask compiles a given Task into an executable Task. It validates all required parameters and ensures a Task
// is well-formed.
func CompileTask(task *core.TaskTemplate) (*core.CompiledTask, error) {
errs := errors.NewCompileErrors()
Expand Down
Loading