This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Remove BarrierTick #545
Merged
Remove BarrierTick #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
pingsutw
approved these changes
Apr 12, 2023
Signed-off-by: Daniel Rammer <[email protected]>
pradithya
pushed a commit
to pradithya/flytepropeller
that referenced
this pull request
Apr 18, 2023
* removed barrier logic Signed-off-by: Daniel Rammer <[email protected]> * deprecated TransitionTypeBarrier Signed-off-by: Daniel Rammer <[email protected]> * removed barrier tests Signed-off-by: Daniel Rammer <[email protected]> * bumping flyteplugins Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Pradithya Aria <[email protected]>
hamersaw
added a commit
that referenced
this pull request
Apr 19, 2023
…ng Vault Secret Manager (#556) * Implement ability to specify additional annotations when using Vault secret manager Signed-off-by: Pradithya Aria <[email protected]> * Infer GOOS and GOARCH from environment (#552) Signed-off-by: Jeev B <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> * fix makefile to read variables from environment and overrides (#554) Signed-off-by: Jeev B <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> * Remove BarrierTick (#545) * removed barrier logic Signed-off-by: Daniel Rammer <[email protected]> * deprecated TransitionTypeBarrier Signed-off-by: Daniel Rammer <[email protected]> * removed barrier tests Signed-off-by: Daniel Rammer <[email protected]> * bumping flyteplugins Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> * Check for TerminateExecution error and eat Precondition status (#553) * Check for TerminateExecution error and eat Precondition status Signed-off-by: Haytham Abuelfutuh <[email protected]> * lint Signed-off-by: Haytham Abuelfutuh <[email protected]> --------- Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> * Rename to annotation Signed-off-by: Pradithya Aria <[email protected]> * Inline merging annotations Signed-off-by: Pradithya Aria <[email protected]> --------- Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: Jeev B <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: Jeev B <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* removed barrier logic Signed-off-by: Daniel Rammer <[email protected]> * deprecated TransitionTypeBarrier Signed-off-by: Daniel Rammer <[email protected]> * removed barrier tests Signed-off-by: Daniel Rammer <[email protected]> * bumping flyteplugins Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
…ng Vault Secret Manager (flyteorg#556) * Implement ability to specify additional annotations when using Vault secret manager Signed-off-by: Pradithya Aria <[email protected]> * Infer GOOS and GOARCH from environment (flyteorg#552) Signed-off-by: Jeev B <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> * fix makefile to read variables from environment and overrides (flyteorg#554) Signed-off-by: Jeev B <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> * Remove BarrierTick (flyteorg#545) * removed barrier logic Signed-off-by: Daniel Rammer <[email protected]> * deprecated TransitionTypeBarrier Signed-off-by: Daniel Rammer <[email protected]> * removed barrier tests Signed-off-by: Daniel Rammer <[email protected]> * bumping flyteplugins Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> * Check for TerminateExecution error and eat Precondition status (flyteorg#553) * Check for TerminateExecution error and eat Precondition status Signed-off-by: Haytham Abuelfutuh <[email protected]> * lint Signed-off-by: Haytham Abuelfutuh <[email protected]> --------- Signed-off-by: Haytham Abuelfutuh <[email protected]> Signed-off-by: Pradithya Aria <[email protected]> * Rename to annotation Signed-off-by: Pradithya Aria <[email protected]> * Inline merging annotations Signed-off-by: Pradithya Aria <[email protected]> --------- Signed-off-by: Pradithya Aria <[email protected]> Signed-off-by: Jeev B <[email protected]> Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: Jeev B <[email protected]> Co-authored-by: Dan Rammer <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
hamersaw
added a commit
that referenced
this pull request
Sep 26, 2023
This reverts commit 0c982ea. Signed-off-by: Daniel Rammer <[email protected]>
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR removes support for Barrier type transitions. It is not clear they are useful and only result in additional overhead and complexity.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#3544
Follow-up issue
NA