Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Infer GOOS and GOARCH from environment #552

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Infer GOOS and GOARCH from environment #552

merged 1 commit into from
Apr 12, 2023

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Apr 11, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #552 (7c6593b) into master (ef164c5) will increase coverage by 0.41%.
The diff coverage is n/a.

❗ Current head 7c6593b differs from pull request most recent head 9d918ea. Consider uploading reports for the commit 9d918ea to get more accurate results

@jeevb
Copy link
Contributor Author

jeevb commented Apr 12, 2023

On cr.flyte.org/flyteorg/flytepropeller:v1.1.78:

/ # uname -a
Linux a05d86425741 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 Linux
/ # file $(which flytepropeller)
/bin/flytepropeller: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=9mFUnu_EIIDDM6S3VL_i/LGdua4NjRkqJgNYbLYgx/AnmJylCQ9MDeRewOeAzn/WveQUbYUDHtt4_4grR3z, not stripped

On this PR:

/ # uname -a
Linux b0a88ef2c62d 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 Linux
/ # file $(which flytepropeller)
/bin/flytepropeller: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=W7Hv7aFDAig6Y9TKJYdQ/2hmlMwojlgm0POMZsudH/5tlaViJh260OeloO-IvN/eo6FcZDzYYu6w3Tu9Jys, not stripped

@jeevb jeevb marked this pull request as ready for review April 12, 2023 04:22
@jeevb jeevb merged commit 2be01e2 into master Apr 12, 2023
@jeevb jeevb deleted the jeev/multiarch branch April 12, 2023 04:22
pradithya pushed a commit to pradithya/flytepropeller that referenced this pull request Apr 18, 2023
hamersaw added a commit that referenced this pull request Apr 19, 2023
…ng Vault Secret Manager (#556)

* Implement ability to specify additional annotations when using Vault secret manager

Signed-off-by: Pradithya Aria <[email protected]>

* Infer GOOS and GOARCH from environment (#552)

Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Pradithya Aria <[email protected]>

* fix makefile to read variables from environment and overrides (#554)

Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Pradithya Aria <[email protected]>

* Remove BarrierTick (#545)

* removed barrier logic

Signed-off-by: Daniel Rammer <[email protected]>

* deprecated TransitionTypeBarrier

Signed-off-by: Daniel Rammer <[email protected]>

* removed barrier tests

Signed-off-by: Daniel Rammer <[email protected]>

* bumping flyteplugins

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Pradithya Aria <[email protected]>

* Check for TerminateExecution error and eat Precondition status (#553)

* Check for TerminateExecution error and eat Precondition status

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Pradithya Aria <[email protected]>

* Rename to annotation

Signed-off-by: Pradithya Aria <[email protected]>

* Inline merging annotations

Signed-off-by: Pradithya Aria <[email protected]>

---------

Signed-off-by: Pradithya Aria <[email protected]>
Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Co-authored-by: Jeev B <[email protected]>
Co-authored-by: Dan Rammer <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]>
eapolinario pushed a commit to eapolinario/flytepropeller that referenced this pull request Aug 9, 2023
eapolinario pushed a commit to eapolinario/flytepropeller that referenced this pull request Aug 9, 2023
…ng Vault Secret Manager (flyteorg#556)

* Implement ability to specify additional annotations when using Vault secret manager

Signed-off-by: Pradithya Aria <[email protected]>

* Infer GOOS and GOARCH from environment (flyteorg#552)

Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Pradithya Aria <[email protected]>

* fix makefile to read variables from environment and overrides (flyteorg#554)

Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Pradithya Aria <[email protected]>

* Remove BarrierTick (flyteorg#545)

* removed barrier logic

Signed-off-by: Daniel Rammer <[email protected]>

* deprecated TransitionTypeBarrier

Signed-off-by: Daniel Rammer <[email protected]>

* removed barrier tests

Signed-off-by: Daniel Rammer <[email protected]>

* bumping flyteplugins

Signed-off-by: Daniel Rammer <[email protected]>

---------

Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Pradithya Aria <[email protected]>

* Check for TerminateExecution error and eat Precondition status (flyteorg#553)

* Check for TerminateExecution error and eat Precondition status

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* lint

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Pradithya Aria <[email protected]>

* Rename to annotation

Signed-off-by: Pradithya Aria <[email protected]>

* Inline merging annotations

Signed-off-by: Pradithya Aria <[email protected]>

---------

Signed-off-by: Pradithya Aria <[email protected]>
Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Co-authored-by: Jeev B <[email protected]>
Co-authored-by: Dan Rammer <[email protected]>
Co-authored-by: Haytham Abuelfutuh <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants