-
Notifications
You must be signed in to change notification settings - Fork 70
move drupal js loading to head, reload scripts #288
Conversation
Hi @evanmwillhite, this looks like it'll solve part of the JS problem I was having earlier today. Quick question though, where is the |
@philwolstenholme thanks for letting me know. There needed to be a companion PR in the attach_library repo. I've created that and referenced it above! |
@philwolstenholme I've tweaked the reloading script here to both wait until the scripts have been loaded and run |
Also, @philwolstenholme I fixed this as a part of it. |
Nevermind, I'm getting inconsistent attachBehaviors experiences depending on the number of scripts loading. Moving back to WIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attempt to fix #287
Companion PR (must be merged together): drupal-pattern-lab/attach-library-twig-extension#7attach_library
Testing:
Notes:
Tested in latest Chrome, Safari and Firefox, IE Edge and 11.