This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Pass document as the value of context to Drupal.attachBehaviors #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't pass a value for context then things like `$('[data-video]', context)` in Drupal behaviors won't work, and code won't be shareable between Drupal and PL.
|
This might need reapplying after #288 is merged in |
philwolstenholme
changed the title
document as the value of context to attachBehaviors
|
@philwolstenholme after the big changes just merged in #288 does this error still occur for you? Note: You'll have to use the develop branch to test since we haven't done a release yet. Thanks! |
evanmwillhite
added
Priority: Medium
Type: Question
Status: Feedback Needed
and removed
Type: Question
labels
|
I went ahead and implemented this (in the new way) because the logic makes sense. I didn't see any functionality regressions within the default Pattern Lab components using javascript, so marking this as needs review since I tweaked the code. |
|
Testing instructions on this one include testing the default Javascript components in Pattern Lab (accordion, menu, etc.) |
mikeethedude
approved these changes
Feb 12, 2019
mikeethedude
added
Status: Passes code review
Status: Passes functional review
and removed
Status: Review Needed
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't pass a value for context then things like
$('[data-video]', context)in Drupal behaviors won't work, and code won't be shareable between Drupal and PL.