Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prompt user to select company for shift & attendance report creation #2461

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: prompt user to select company for shift & attendance report creation #2461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6b6c77
fix: prompt user to select company for report shift & attendance repo…
AyshaHakeem Nov 27, 2024
7166753
fix: remove unused brackets from if condition
ruchamahabal Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hrms/hr/report/monthly_attendance_sheet/monthly_attendance_sheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ def execute(filters: Filters | None = None) -> tuple:
if not (filters.month and filters.year):
frappe.throw(_("Please select month and year."))

if not filters.company:
frappe.throw(_("Please select company."))

if filters.company:
filters.companies = [filters.company]
if filters.include_company_descendants:
Expand Down
Loading