fix: prompt user to select company for shift & attendance report creation #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
reviewed
Dec 4, 2024
hrms/hr/report/monthly_attendance_sheet/monthly_attendance_sheet.py
Outdated
Show resolved
Hide resolved
ruchamahabal
approved these changes
Dec 4, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…tion (#2461) Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 3776c60)
mergify bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
…tion (#2461) Co-authored-by: Rucha Mahabal <[email protected]> (cherry picked from commit 3776c60)
ruchamahabal
added a commit
that referenced
this pull request
Dec 4, 2024
…tion (backport #2461) (#2474) Co-authored-by: Rucha Mahabal <[email protected]> Co-authored-by: Aysha <[email protected]>
ruchamahabal
added a commit
that referenced
this pull request
Dec 4, 2024
…tion (backport #2461) (#2475) Co-authored-by: Rucha Mahabal <[email protected]> Co-authored-by: Aysha <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
## [14.35.3](v14.35.2...v14.35.3) (2024-12-09) ### Bug Fixes * Apply system precision value while validating leave balance (backport [#2482](#2482)) ([#2490](#2490)) ([8d9f676](8d9f676)) * prompt user to select company for shift & attendance report creation (backport [#2461](#2461)) ([#2474](#2474)) ([9ef4001](9ef4001))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
# [15.36.0](v15.35.3...v15.36.0) (2024-12-09) ### Bug Fixes * Apply system precision value while validating leave balance (backport [#2482](#2482)) ([#2489](#2489)) ([4d2c5f6](4d2c5f6)) * prompt user to select company for shift & attendance report creation (backport [#2461](#2461)) ([#2475](#2475)) ([2bfd0b0](2bfd0b0)) * render correct date in job listing web view (backport [#2464](#2464)) ([#2478](#2478)) ([4e2b6ea](4e2b6ea)) * **Salary Assignment:** skip warning for missing opening entries in the absence of tax components (backport [#2472](#2472)) ([#2477](#2477)) ([531d16b](531d16b)) ### Features * add Absent Days column to salary register (backport [#2485](#2485)) ([#2493](#2493)) ([67077ee](67077ee))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alert the user to select a company to create and view the Shift & Attendance report. Previously, missing the company filter resulted in an error message since this is a mandatory filter. This is if global default company is not set.
Before:
After:
