Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Remove redundant custom chunk preloading code #451

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Remove redundant custom chunk preloading code #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c60c1d0
Remove redundant custom chunk preloading code
rtsao Jul 27, 2018
0fa35e9
Upgrade fusion-core
rtsao Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 0 additions & 72 deletions build/chunk-preload-plugin.js
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions build/compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const resolveFrom = require('resolve-from');

const AssetsManifestPlugin = require('./file-loader-asset-manifest-plugin');
const ClientSourceMapPlugin = require('./client-source-map-plugin');
const ChunkPreloadPlugin = require('./chunk-preload-plugin');
const ChunkModuleManifestPlugin = require('./chunk-module-manifest-plugin');
const chunkModuleManifest = require('./chunk-module-manifest');
const InstrumentedImportDependencyTemplatePlugin = require('./instrumented-import-dependency-template-plugin');
Expand Down Expand Up @@ -447,9 +446,6 @@ function getConfig({target, env, dir, watch, cover}) {
env === 'production' &&
target === 'web' &&
new webpack.HashedModuleIdsPlugin(),
target === 'web' && env !== 'test' && new ChunkPreloadPlugin(),
// TODO(#11): What do we do for client-side error reporting in the service worker?
// Do we add in reporting code to the sw? Should we map stack traces on the server?
target === 'web' && new ClientSourceMapPlugin(),
target === 'web' && new SyncChunkIdsPlugin(),
target === 'web' &&
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"eslint-plugin-prettier": "2.6.2",
"eslint-plugin-react": "^7.10.0",
"flow-bin": "0.77.0",
"fusion-core": "^1.4.1",
"fusion-core": "^1.5.0-beta.0",
"fusion-plugin-i18n-react": "^1.0.4",
"fusion-plugin-react-router": "^1.1.3",
"fusion-react": "^1.1.0",
Expand All @@ -104,7 +104,7 @@
},
"peerDependencies": {
"enzyme": "^3.3.0",
"fusion-core": "^1.3.1",
"fusion-core": "^1.5.0-beta.0",
"fusion-tokens": "^1.0.4"
},
"engines": {
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3335,9 +3335,9 @@ functional-red-black-tree@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/functional-red-black-tree/-/functional-red-black-tree-1.0.1.tgz#1b0ab3bd553b2a0d6399d29c0e3ea0b252078327"

fusion-core@^1.4.1:
version "1.4.1"
resolved "https://registry.yarnpkg.com/fusion-core/-/fusion-core-1.4.1.tgz#22daeddeefa3125b056cdcccd9c6dd486d7f032e"
fusion-core@^1.5.0-beta.0:
version "1.5.0-beta.0"
resolved "https://registry.yarnpkg.com/fusion-core/-/fusion-core-1.5.0-beta.0.tgz#30c36bdd75edef51bd828008bc7d11e61c8ac5e1"
dependencies:
koa "^2.4.1"
koa-compose "^4.0.0"
Expand Down