Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Remove redundant custom chunk preloading code #451

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Conversation

rtsao
Copy link
Member

@rtsao rtsao commented Jul 27, 2018

This code was a workaround to allow for async chunks to be preloaded (without being fetched twice) with webpack 3 (Fusion was originally implemented before webpack 4 was released).

The need for this workaround is no longer needed as it has been fixed in webpack 4 (this is the relevant PR).

Copy link
Contributor

@KevinGrandon KevinGrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have access to this information? Pretty soon we're going to be implementing service workers which will need to know all of the "initial", and non-dynamic scripts for a page so we can cache them for a second load.

@rtsao
Copy link
Member Author

rtsao commented Jul 27, 2018

Yep, the information gathering part is still all there, this plugin was just for making the webpack 3 runtime able to see if some async chunks were already preloaded (which isn't needed anymore since this works out of the box in webpack 4)

@KevinGrandon
Copy link
Contributor

LGTM then, happy to review once tests are passing.

@rtsao rtsao changed the title Remove redundant custom chunk preloading code [WIP] Remove redundant custom chunk preloading code Jul 27, 2018
@rtsao rtsao changed the title [WIP] Remove redundant custom chunk preloading code Remove redundant custom chunk preloading code Aug 1, 2018
@rtsao
Copy link
Member Author

rtsao commented Aug 1, 2018

!merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants