Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows applications to use templated types #244

Closed
Groovounet opened this issue Oct 5, 2014 · 4 comments
Closed

Allows applications to use templated types #244

Groovounet opened this issue Oct 5, 2014 · 4 comments
Assignees
Milestone

Comments

@Groovounet
Copy link
Member

In theory, applications are not supposed to use templated types as there are in the detail namespace. This is very inconvenient.

Move tvec* and tmat* to glm namespace.

@richardeakin
Copy link

Thanks for this, we were using the detail::tvec/tmat's wherever we had templated functions that operated on multiple value types or dimensions (like here), but this change will make it appear less hacky.

@Groovounet
Copy link
Member Author

Welcome!

Note that GLM provides "areOrthogonal" function in GTX_vector_query.

@Groovounet
Copy link
Member Author

'slerp' is also implemented in GTX_rotate_vector.

@richardeakin
Copy link

Our orthogonal() method is a bit different as it returns a new vec3 orthogonal to the provided argument. We'll be happy to move to the slerp() you added when upgrading to 0.9.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants