Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved from our own math library to glm and noticed some difference. For example we had something like this in our codebase:
Note that this works as long as
normalize
is defined in the same namespace as the vectortype (this is how ADL works). I was hoping that we could change to glm by just changing the typedefs. However in this casenormalize
could not be found, asnormalize
is not in the namespaceglm::detail
.In order to let this work I made this header (as an extension of course), which injects all glsl functions in the
glm::detail
namespace.Pros:
using namespace glm;
.Cons:
Fun fact: there is a one-line trick to inject the detail namespace into the glm namespace: http://ideone.com/ZqUiHX (the hack is on line 20). But this is just weird ;).
Any thoughts?