Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format and Information sheet format fields not populated in GN CSW catalog source #9295

Closed
1 task done
tdipisa opened this issue Jul 21, 2023 · 5 comments · Fixed by #9712 or #9732
Closed
1 task done

Format and Information sheet format fields not populated in GN CSW catalog source #9295

tdipisa opened this issue Jul 21, 2023 · 5 comments · Fixed by #9712 or #9732

Comments

@tdipisa
Copy link
Member

tdipisa commented Jul 21, 2023

Description

Contents for Format and Information sheet format fields are not properly fetched in Advanced Settings of a GeoNetwork CWS catalog source (eg. using this in c027 VPN).

How to reproduce

  • Open the map viewer and configure a CSW source against GeoNetwork
  • Open the advanced settings and try to expand the Format or Information sheet format fiels

Expected Result

Contents in drop down are fetched

Current Result

Contents in drop down are not fetched. Wrong request performed by MS in this case

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@MV88
Copy link
Contributor

MV88 commented Nov 15, 2023

hi @tdipisa

As discussed with @allyoucanmap we can propose this to resolve this issue

  • No need to create a dedicated geonetwork service type
  • We can handle the failure of the request and show an alert box just below the information sheet format with a generic explanation why it has failed with a status of an error ("danger" bootstrap)
  • Message could be: "it was not possible to fetch format and information sheet format from the service configured. Probably you are using a no vendor service and this is not supported (geonetwork)"
  • if user changes url we can remove the alert box

@tdipisa
Copy link
Member Author

tdipisa commented Nov 16, 2023

  • No need to create a dedicated geonetwork service type

I agree with that

  • We can handle the failure of the request and show an alert box just below the information sheet format with a generic explanation why it has failed with a status of an error ("danger" bootstrap)

Ok, but see my note below.

  • Message could be: "it was not possible to fetch format and information sheet format from the service configured. Probably you are using a no vendor service and this is not supported (geonetwork)"

better "...you are using a No Vendor service and this is not supported (e.g. GeoNetwork)""

See my note below.

  • if user changes url we can remove the alert box

Yes, but In my opinion the alert box should also disappear after a while, if the user stays in the panel, to appear again if the user tries to select a Format a second time.

What do you think about adding instead a alert icon beside the Format and Info sheet format fields with a popup appearing showing the message above when the user move the mouse hover it (in case of No Vendor selected as Service Type) ?

As also discussed with @allyoucanmap the Service Type should stay on top because it indicates a priority field.

image

@MV88
Copy link
Contributor

MV88 commented Nov 16, 2023

@tdipisa
The reason behind the alert box is the "visibility of the message"

  • an alert box is fully visible from the start it appears, no hover action required
  • it should be used to communicate info that user must not miss
  • normally they do not disappear after a while

We proposed the alert box because we wanted to provide a visible feedback to the user based on his action.

As also discussed with @allyoucanmap the Service Type should stay on top because it indicates a priority field.

Good that you provided the screenshot because I thought you wanted to have it just above the format field.

@tdipisa
Copy link
Member Author

tdipisa commented Nov 16, 2023

let's talk

@MV88
Copy link
Contributor

MV88 commented Nov 16, 2023

Final ACs

  • move Server Type just above Format
  • if user clicks on format and an error occurs
    • a red icon appears on the far right
    • it will show from the start a tooltip in a disposable popover
    • Message will be "It was not possible to fetch format and information sheet format from the service configured. Probably you are using a No Vendor service and this is not supported (e.g. GeoNetwork)"
    • user can click to dispose the popover
    • if user changes url we can remove this icon and error state
  • if user select No Vendor in Server Type
    • format field gets disabled
    • information sheet format field gets disabled

MV88 added a commit to MV88/MapStore2 that referenced this issue Nov 16, 2023
@tdipisa tdipisa modified the milestones: 2023.02.02, 2023.02.01 Nov 17, 2023
MV88 added a commit that referenced this issue Nov 22, 2023
* Fix #9295 added better handling of format in csw service
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 22, 2023
@ElenaGallo ElenaGallo self-assigned this Nov 22, 2023
MV88 added a commit to MV88/MapStore2 that referenced this issue Nov 22, 2023
…ce (geosolutions-it#9712)

* Fix geosolutions-it#9295 added better handling of format in csw service

# Conflicts:
#	web/client/themes/default/less/common.less
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 22, 2023
tdipisa pushed a commit that referenced this issue Nov 27, 2023
* Fix #9624 Point cloud shading options (#9666)

* Fix #9666 Include pointCloudShading option to saved layer config (#9670)

* #9606 Error with circle annotations + radius selection (#9607) (#9727)

Co-authored-by: Diego Vargas <[email protected]>

* Fix #9295 added better handling of format in csw service (#9712) (#9732)

* #9702: Fix - Background selector in contexts won't retain thumbnail in view mode (#9720) (#9744)

* #9567: handle functionality of zoom to record in table widgets (#9608)

* #9567: handle functionality of zoom to record in table widgets

* Fix: Correct failing test cases for zoom records issue in table widgets (#9567)
This commit addresses the failing test cases related to the issue of zoom records in table widgets.
* #9567: implement the new approach in zoom to records in table widgets + writing unit tests
* #9567: handle adding flag into config file to show/hide zoom icon for tblWidget
* #9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer
* #9567: resolve comments' review:
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead

* #9683: add Details Panel for MS dashboard (#9689)

* #9683: add Details Panel for MS dashboard
-  The tool have the same options (eg. show as modal, show at startup etc.)
- The tool is defined in the same way of the corresponding one for maps.
- Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

* #9683: resolve the FE test

Update DashboardEditor.jsx

* #9683: resolve review comments
* description:
- remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard.
- add missing test for detailsLoaded action
- create new selectors, details uri selector and details settings se;ector that are used in many places in code
- move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder
- Put global spinner in details plugin and remove it from sidebar plugin
-  edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard
- Add custom style in details.less as the lib of react-dock doesn't allow to override left css property
- remove unused added style from panels.less

* #9683: remove unused comments in dashboard-test file

* #9683: edit in details epics and selectors to fix FE test

* #9683: Resolve review comments
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style

* #9683: resolve review comments
Description:
- edit navbar.less files to fix going language selector behind body panel
- remove unused z-index in dashboard.less
# Conflicts:
#	web/client/epics/__tests__/config-test.js
#	web/client/epics/config.js

* #9683: resolve test comment (#9730)

- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard

* #9683: add Details Panel for MS dashboard [Editing the detail panel tooltip and title]  (#9740)

* #9683: resolve test comment
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: Matteo V <[email protected]>

* #9728 fix misalignement issue (#9731) (#9742)

* Fix #9729 fixed formats in catalog used in dashboard (#9733) (#9747)

---------

Co-authored-by: stefano bovio <[email protected]>
Co-authored-by: Diego Vargas <[email protected]>
Co-authored-by: Suren <[email protected]>
Co-authored-by: mahmoud adel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment