Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom to record in table widgets #9567

Closed
1 of 12 tasks
mahmoudadel54 opened this issue Oct 6, 2023 · 1 comment · Fixed by #9608
Closed
1 of 12 tasks

Zoom to record in table widgets #9567

mahmoudadel54 opened this issue Oct 6, 2023 · 1 comment · Fixed by #9608
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Milestone
2024.01.00

Comments

@mahmoudadel54
Copy link
Contributor

mahmoudadel54 commented Oct 6, 2023 •
edited by tdipisa
Loading

Description

At the moment table widgets can be defined for both map viewer and dashboards but it is not possible to zoom a map to the selected record.

It is requested to include a zoom icon on the left side of each record to allow the zoom operation:

  • to the related layer feature the table widget is referring to (in case of map viewer)
  • to the related feature extent in the map widget the table widget is connected to (in case of dashboards)

EDIT: adding here some details on how it can be the ideal workflow:

  • The zoom to button must be always visible in the table widgets: please include a new configuration option at plugin json config level to include it or not (default to true)
  • geometry need to be fetched on demand and should never appear in the list of attributes
  • when you click the zoom button of a feature, it starts fetching the geom of that feature or
    better only the extent if possible trough a WFS call
  • in the meantime a spinner takes the place of the zoom button
  • when the response is back we can trigger the zoomToExtent action
  • and restore zoom to button

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information
@mahmoudadel54 mahmoudadel54 self-assigned this Oct 6, 2023
@mahmoudadel54 mahmoudadel54 modified the milestones: 2023.02.01, 2024.01.00 Oct 6, 2023
@mahmoudadel54 mahmoudadel54 mentioned this issue Oct 6, 2023
Closed
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 16, 2023
@mahmoudadel54
geosolutions-it#9567: handle functionality of zoom to record in table…
90ba37c 
… widgets
@mahmoudadel54 mahmoudadel54 mentioned this issue Oct 16, 2023
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Oct 16, 2023 that will close this issue
#9567: handle functionality of zoom to record in table widgets #9608
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 16, 2023
@mahmoudadel54
Fix: Correct failing test cases for zoom records issue in table widge…
6b2667d 
…ts (geosolutions-it#9567)

This commit addresses the failing test cases related to the issue of zoom records in table widgets.
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 25, 2023
@mahmoudadel54
geosolutions-it#9567: implement the new approach in zoom to records i…
73d51f8 
…n table widgets + writing unit tests
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 25, 2023
@mahmoudadel54
geosolutions-it#9567: handle adding flag into config file to show/hid…
d726313 
…e zoom icon for tblWidget
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 25, 2023
@mahmoudadel54
geosolutions-it#9567: reset flag enableZoomInTblWidget to be true for…
16b1eef 
… dashboard and map viewer
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 31, 2023
@mahmoudadel54
geosolutions-it#9567: resolve comments' review:
9d8beee 
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead
-
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 6, 2023
@mahmoudadel54
geosolutions-it#9567: resolve review comments
0d9a5a0
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 9, 2023
@mahmoudadel54
geosolutions-it#9567: resolve comments' review
84642c1
MV88 pushed a commit that referenced this issue Nov 10, 2023
@mahmoudadel54
#9567: handle functionality of zoom to record in table widgets (#9608)
2c89454 
* #9567: handle functionality of zoom to record in table widgets

* Fix: Correct failing test cases for zoom records issue in table widgets (#9567)
This commit addresses the failing test cases related to the issue of zoom records in table widgets.
* #9567: implement the new approach in zoom to records in table widgets + writing unit tests
* #9567: handle adding flag into config file to show/hide zoom icon for tblWidget
* #9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer
* #9567: resolve comments' review:
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead
@ElenaGallo ElenaGallo self-assigned this Nov 13, 2023
@ElenaGallo ElenaGallo mentioned this issue Nov 16, 2023
Closed
2 tasks
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 24, 2023
@MV88
Copy link
Contributor

MV88 commented Nov 24, 2023

this has to be backported in c040-2023.02.xx

MV88 pushed a commit to MV88/MapStore2 that referenced this issue Nov 24, 2023
@mahmoudadel54 @MV88
geosolutions-it#9567: handle functionality of zoom to record in table…
be4dfce 
… widgets (geosolutions-it#9608)

* geosolutions-it#9567: handle functionality of zoom to record in table widgets

* Fix: Correct failing test cases for zoom records issue in table widgets (geosolutions-it#9567)
This commit addresses the failing test cases related to the issue of zoom records in table widgets.
* geosolutions-it#9567: implement the new approach in zoom to records in table widgets + writing unit tests
* geosolutions-it#9567: handle adding flag into config file to show/hide zoom icon for tblWidget
* geosolutions-it#9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer
* geosolutions-it#9567: resolve comments' review:
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead
@MV88 MV88 mentioned this issue Nov 24, 2023
Merged
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 27, 2023
@mahmoudadel54
geosolutions-it#9567: handle functionality of zoom to record in table…
b3fa4bc 
… widgets (geosolutions-it#9608)

* geosolutions-it#9567: handle functionality of zoom to record in table widgets

* Fix: Correct failing test cases for zoom records issue in table widgets (geosolutions-it#9567)
This commit addresses the failing test cases related to the issue of zoom records in table widgets.
* geosolutions-it#9567: implement the new approach in zoom to records in table widgets + writing unit tests
* geosolutions-it#9567: handle adding flag into config file to show/hide zoom icon for tblWidget
* geosolutions-it#9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer
* geosolutions-it#9567: resolve comments' review:
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead
@mahmoudadel54 mahmoudadel54 mentioned this issue Nov 27, 2023
Closed
@mahmoudadel54 mahmoudadel54 linked a pull request Nov 27, 2023 that will close this issue
[Backport C040-2023.02.xx] #9567: handle functionality of zoom to record in table widgets (#9608) #9749
Closed
tdipisa pushed a commit that referenced this issue Nov 27, 2023
@MV88 @allyoucanmap
@diegovargasg @dsuren1 @mahmoudadel54
updating stable branch of genova (#9748)
e257122 
* Fix #9624 Point cloud shading options (#9666)

* Fix #9666 Include pointCloudShading option to saved layer config (#9670)

* #9606 Error with circle annotations + radius selection (#9607) (#9727)

Co-authored-by: Diego Vargas <[email protected]>

* Fix #9295 added better handling of format in csw service (#9712) (#9732)

* #9702: Fix - Background selector in contexts won't retain thumbnail in view mode (#9720) (#9744)

* #9567: handle functionality of zoom to record in table widgets (#9608)

* #9567: handle functionality of zoom to record in table widgets

* Fix: Correct failing test cases for zoom records issue in table widgets (#9567)
This commit addresses the failing test cases related to the issue of zoom records in table widgets.
* #9567: implement the new approach in zoom to records in table widgets + writing unit tests
* #9567: handle adding flag into config file to show/hide zoom icon for tblWidget
* #9567: reset flag enableZoomInTblWidget to be true for dashboard and map viewer
* #9567: resolve comments' review:
- put flag of zoomInTblWidget as a default prop
- add translations
- edit zoomToExtent enhancer to use internal zoom
- remove selector "getFlagOfShowingTblWidgetZoom " and use plugin prop instead

* #9683: add Details Panel for MS dashboard (#9689)

* #9683: add Details Panel for MS dashboard
-  The tool have the same options (eg. show as modal, show at startup etc.)
- The tool is defined in the same way of the corresponding one for maps.
- Edit the layout to put add widget & show/hide connection buttons to the sidebar menu

* #9683: resolve the FE test

Update DashboardEditor.jsx

* #9683: resolve review comments
* description:
- remove all dashboard selectors and pieces of code in generic components like sidebar plugin component that relevant to dashboard.
- add missing test for detailsLoaded action
- create new selectors, details uri selector and details settings se;ector that are used in many places in code
- move AddWidgetDashboard, MapConnedctionDashboard plugins to direct plugins folder
- Put global spinner in details plugin and remove it from sidebar plugin
-  edit in handleSave enhancer file to make update attributes of details just implemented for Map and Dashboard
- Add custom style in details.less as the lib of react-dock doesn't allow to override left css property
- remove unused added style from panels.less

* #9683: remove unused comments in dashboard-test file

* #9683: edit in details epics and selectors to fix FE test

* #9683: Resolve review comments
Description:
- Reolve unused loading property from DashoardEditor file
- Add tooltip for save dashboard
- Remove custom style in BorderLayout and leave it with generic style

* #9683: resolve review comments
Description:
- edit navbar.less files to fix going language selector behind body panel
- remove unused z-index in dashboard.less
# Conflicts:
#	web/client/epics/__tests__/config-test.js
#	web/client/epics/config.js

* #9683: resolve test comment (#9730)

- Adding export, import, delete dashboard
- Reorder shown plugins in sidebar for dashboard

* #9683: add Details Panel for MS dashboard [Editing the detail panel tooltip and title]  (#9740)

* #9683: resolve test comment
Description:
- edit the detail panel tooltip and shown title and make it generic one
- Add translations for the new tooltip

* Update web/client/translations/data.it-IT.json

---------

Co-authored-by: Matteo V <[email protected]>

* #9728 fix misalignement issue (#9731) (#9742)

* Fix #9729 fixed formats in catalog used in dashboard (#9733) (#9747)

---------

Co-authored-by: stefano bovio <[email protected]>
Co-authored-by: Diego Vargas <[email protected]>
Co-authored-by: Suren <[email protected]>
Co-authored-by: mahmoud adel <[email protected]>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 27, 2023
@tdipisa tdipisa mentioned this issue Dec 4, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Projects
None yet
Milestone
2024.01.00
4 participants
@tdipisa @MV88 @ElenaGallo @mahmoudadel54