Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make COG Source type disabled by default until experimental #9592

Closed
1 of 6 tasks
Tracked by #9593
tdipisa opened this issue Oct 12, 2023 · 1 comment · Fixed by #9684 or #9699
Closed
1 of 6 tasks
Tracked by #9593

Make COG Source type disabled by default until experimental #9592

tdipisa opened this issue Oct 12, 2023 · 1 comment · Fixed by #9684 or #9699

Comments

@tdipisa
Copy link
Member

tdipisa commented Oct 12, 2023

Description

COG source type should be excluded from the default configuration until this feature is experimental. The way for MS admins to add it by configuration should be anyway maintained. Intervention area:

  • Catalog tool in viewer: it is enough to properly configure serviceTypes if we want to add COG. Remove from default
  • Catalog tool in dashboard: it is not present (nothing to do)
  • Catalog tool in geostories: to be implemented the possibility to configure it or simply change the default config by making it different between various resource types

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

@tdipisa tdipisa self-assigned this Oct 12, 2023
@tdipisa tdipisa added this to the 2023.02.01 milestone Oct 12, 2023
@tdipisa tdipisa mentioned this issue Oct 12, 2023
6 tasks
@tdipisa tdipisa assigned dsuren1 and unassigned tdipisa Oct 13, 2023
@tdipisa tdipisa added Internal BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch estimate needed labels Oct 13, 2023
@tdipisa tdipisa assigned offtherailz and unassigned dsuren1 Oct 13, 2023
@tdipisa tdipisa assigned dsuren1 and unassigned offtherailz Nov 3, 2023
@dsuren1
Copy link
Contributor

dsuren1 commented Nov 6, 2023

@tdipisa

  • Catalog tool in viewer: it is enough to properly configure serviceTypes if we want to add COG. Remove from default
  • Catalog tool in geostories: to be implemented the possibility to configure it or simply change the default config by making it different between various resource types

Removing from default (serviceTypes) in MetadataExplorer plugin should be enough to hide COG option from catalog in Map and Geostory's MapEditor

If needs to be configured differently in two places, we can configure it in MapEditor's DefaultConfigurations. But I think, for now this is not needed.

Additionally
Add a warning note (Experimental funtionality) https://docs.mapstore.geosolutionsgroup.com/en/latest/user-guide/catalog/#cog-catalog, explaning the user how to enable the COG option from MetadataExplorer plugin configuration

dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 8, 2023
@dsuren1 dsuren1 linked a pull request Nov 8, 2023 that will close this issue
5 tasks
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 14, 2023
offtherailz pushed a commit that referenced this issue Nov 16, 2023
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment