Improve Date/DateTime type parameters

[kravets-levko]

Issue #2642

Default date/time inputs replaced with Ant Date/Time picker.

Screenshots:

Date:

Date/Time:

Date/Time with seconds (same as Date/Time but different format):

[vercel]

Since this Pull Request originated from a forked repository, Now cannot deploy it as there are potential security risks.

If you are a collaborator on this repository, consider making this Pull Request from a branch on the same repository instead of a fork.

[arikfr]

Looks good and much less code than I expected this to be 😅

See some comments.

Also try to "stress" test it with a few edge case. I remember the browser default input field had issues where it would show a value but actually have a null value.

[arikfr]

Why not use the following?

this.updateValue = value => this.ngModel = value;

(=> instead of .bind(this))

[kravets-levko]

oh, missed it, you're right

[arikfr]

Select Date

[arikfr]

Also seems that we don't really use it customer placeholders. Maybe just pass a static value?

[arikfr]

One more question: how does it look side by side with regular input fields?

[kravets-levko]

@arikfr Updated PR.

how does it look side by side with regular input fields?

A bit different. I'm not sure - should I fix the CSS, or it's better if @kocsmy will do it? WDYT?

[kravets-levko]

Also try to "stress" test it with a few edge case. I remember the browser default input field had issues where it would show a value but actually have a null value.

I tried to use it from users perspective - and it works as it should: it displays value if there is value set, and it shows placeholder when param does not have value set.

[arikfr]

A bit different. I'm not sure - should I fix the CSS, or it's better if @kocsmy will do it? WDYT?

There are 3 options here:

1. Change the Ant component to look like ours (or at least align properly).
2. Change ours to look like Ant.
3. Use Ant's Input component.

@kocsmy what are your thoughts?

[kocsmy]

Hmm, it should be fairly simple to change their design to look like ours but if we plan to use more of Ant components or even use their whole library, then that's a bigger plan :)

[arikfr]

Merged 🤩

[arikfr]

@kocsmy

Hmm, it should be fairly simple to change their design to look like ours but if we plan to use more of Ant components or even use their whole library, then that's a bigger plan :)

We will use more and more of their components to the point where we can say that we use the whole lib :)

I merged this already so give this a look and see what's the simplest thing we can do to make it look less alien, before we commit to a bigger plan.

[kocsmy]

Sure, I'll take a look and see if we can improve this quickly.