This repository has been archived by the owner on Jan 11, 2025. It is now read-only.
fix: Correctly use test image #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaslavsky
approved these changes
May 29, 2024
| echo "${image_var}=${{ inputs.image_url }}" >> .env.custom | ||
| cat .env.custom | ||
| sed -i "/^$image_var/d" .env | ||
| echo "${image_var}=${{ inputs.image_url }}" >> .env |
There was a problem hiding this comment.
Can we still cat the .env file? I think this is used to make test logs a bit more informative.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in relay/snuba likely weren't being properly run with the pre-submit images that were built. This led to an event today where a change led to self-hosted e2e test breakage in relay on master that was not caught on the PR. I suspect the custom env file for every commit on a PR wasn't being used for e2e tests that is built here: https://github.com/getsentry/action-self-hosted-e2e-tests/blob/main/action.yml#L64. In the meantime, I think directly writing to the .env file is fine for now, and it works as I have verified in https://github.com/getsentry/self-hosted/actions/runs/9293290182/job/25576089323?pr=3094