feat(spans): Add separate feature flags for add-ons span metrics and indexed spans #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
May 23, 2024
…te-am3-feature-flags
This reverts commit e6a88a6.
Dav1dde
reviewed
May 29, 2024
jjbayer
approved these changes
May 29, 2024
Co-authored-by: David Herberth <[email protected]>
This was referenced May 29, 2024
hubertdeng123
added a commit
that referenced
this pull request
May 31, 2024
…3666) I've recently updated the self-hosted e2e test action to properly pick up changes on pre-submit after noticing breakage snuck into master from #3633. It seems reasonable to pin this to main given that our team has alerting for when this CI check fails on master, and we don't update it frequently. Please let me know if there are any concerns here. #skip-changelog
jjbayer
added a commit
that referenced
this pull request
Jun 12, 2024
#3633 introduced separate feature flags for span extraction and span metrics, but this meant that there was no usage metric for spans that were extracted without common span metrics. We need the usage metric for accounting purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR
projects:span-metrics-extractionwill only control the set of "common" metrics. It no longer controls indexed span extraction.projects:span-metrics-extraction-addonsin addition toprojects:span-metrics-extractionwill extract additional metrics for theai,queueandcachemodules.organizations:indexed-spans-extractioncontrols whether spans are extracted from transaction payloads. This flag is now independent of the metrics-related flags.