fix(build): Fetch with cli while updating the registry index #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Nov 7, 2022
| @@ -51,7 +51,8 @@ ENV RELAY_FEATURES=${RELAY_FEATURES} | |||
| COPY . . | |||
|
|
|||
| # Build with the modern compiler toolchain enabled | |||
| RUN scl enable devtoolset-10 llvm-toolset-7.0 -- \ | |||
| RUN echo -e "[net]\ngit-fetch-with-cli = true" > $CARGO_HOME/config \ | |||
| && scl enable devtoolset-10 llvm-toolset-7.0 -- \ | |||
There was a problem hiding this comment.
This can also be set on the command line, but I'm not sure if we want to change the Makefile for this. Maybe we can just insert a RUN cargo --config net.git-fetch-with-cli=true fetch before this command?
There was a problem hiding this comment.
For reference, in symbolic it's been done like this: getsentry/symbolic#585
Ideally we fix this for the binary and library builds alike.
There was a problem hiding this comment.
Excuse me, what does this command means (effect) in this case ? RUN cargo --config net.git-fetch-with-cli=true fetch @jjbayer
There was a problem hiding this comment.
@jan-auer yeah, so that's what this PR does as well, just adds the config for cargo with same option.
|
👀 |
|
|
iker-barriocanal
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like docker build was killed because it used too much memory while updating the registry index, when forcing cargo to use cli, I could pass the step when the index is updated and successfully build the image.
Fixes #1559
It seems related to rust-lang/cargo#9167
#skip-changelog