Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): use cli git to save some ram with cargo #585

Merged
merged 1 commit into from
May 20, 2022

Conversation

asottile-sentry
Copy link
Member

@asottile-sentry asottile-sentry commented May 20, 2022

see rust-lang/cargo#9167

cargo without this setting uses libgit2 which appears to have a pretty bad memory leak (consuming ~9GB of ram and then never freeing it) -- later leading to an out-of-memory (docker exits with code 247)

on my x86_64 linux VM emulating arm64 via qemu this reduces the maximum memory usage of the build process from ~13GB to 2.7GB

test run here: https://github.com/getsentry/symbolic/runs/6530937203?check_suite_focus=true

@asottile-sentry asottile-sentry marked this pull request as ready for review May 20, 2022 21:05
@asottile-sentry asottile-sentry requested a review from a team May 20, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants