feat(spans): Ignore more spans for the DB module #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Sep 20, 2023
jan-auer
approved these changes
Sep 20, 2023
relay-server/src/actors/processor.rs
Outdated
| @@ -2283,6 +2284,8 @@ impl EnvelopeProcessorService { | |||
| .project_state | |||
| .has_feature(Feature::SpanMetricsExtractionAllModules); | |||
|
|
|||
| let op_denylist = HashSet::from(["clickhouse", "mongodb", "redis", "activerecord"]); | |||
There was a problem hiding this comment.
This constructs a data structure for static data in every run. Instead of this, you could make this a function that uses match to check for the four allowed values.
There was a problem hiding this comment.
I ended up refactoring the conditions so it's just code. Let me know if that's better.
jan-auer
added a commit
that referenced
this pull request
Sep 22, 2023
* master: fix(spans): Handle ActiveRecord official and custom spelling (#2525) feat(spans): Update db table extraction to add comma separators (#2521) fix(profiling): Remove profile ID from transaction context if no profile is found in the envelope (#2523) feat(spans): Ignore more spans for the DB module (#2522) release: 23.9.1 release: 23.9.0 fix(spans): Add a description to the segment as well (#2512) fix(spans): Filter DB spans for MongDB queries (#2520)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've found more problematic spans we'd like to ignore as our grouping gets better.
https://www.notion.so/sentry/Problematic-Projects-During-Database-View-V0-Rollout-463d6f3f1f3d47baa127c97cf0e56716