Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): Remove profile ID from transaction context if no profile is found in the envelope #2523

Merged

Conversation

phacops
Copy link
Contributor

@phacops phacops commented Sep 20, 2023

Some SDKs might send us a profile context in the transaction, containing a profile ID, when they're not supposed to.

@phacops phacops requested review from a team and Zylphrex September 20, 2023 22:02
relay-server/src/actors/processor.rs Outdated Show resolved Hide resolved
@phacops phacops requested review from jjbayer and a team September 21, 2023 10:55
@phacops phacops enabled auto-merge (squash) September 21, 2023 11:11
@phacops phacops merged commit c55d0e3 into master Sep 21, 2023
@phacops phacops deleted the pierre/profiling-refactor-to-remove-profile_id-if-no-profile branch September 21, 2023 12:10
jan-auer added a commit that referenced this pull request Sep 22, 2023
* master:
  fix(spans): Handle ActiveRecord official and custom spelling (#2525)
  feat(spans): Update db table extraction to add comma separators (#2521)
  fix(profiling): Remove profile ID from transaction context if no profile is found in the envelope (#2523)
  feat(spans): Ignore more spans for the DB module (#2522)
  release: 23.9.1
  release: 23.9.0
  fix(spans): Add a description to the segment as well (#2512)
  fix(spans): Filter DB spans for MongDB queries (#2520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants