fix(spans): Prevent duplicate extraction of score.total metric #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
jjbayer
force-pushed
the
fix/transaction-metrics-2x
branch
from
3151bf8 to
b359e1f
Compare
jjbayer
commented
Mar 25, 2024
| ): | ||
| score_total_seen += 1 | ||
|
|
||
| assert score_total_seen == 1 |
There was a problem hiding this comment.
Without the extra condition, this test fails with 2 == 1.
Dav1dde
approved these changes
Mar 25, 2024
edwardgou-sentry
added a commit
to getsentry/sentry
that referenced
this pull request
Jul 2, 2024
…lculation workaround (#73506) It has been over 90 days since we fixed an issue with double counting transactions (getsentry/relay#3324), so we no longer need this score calculation workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3273, we accidentally emit the metric
d:transactions/measurements.score.total@ratiotwice for every transaction.This happens because the metric is not only extracted from transactions, but also from spans:
relay/relay-dynamic-config/src/defaults.rs
Lines 459 to 461 in 0b8687c
As a quick fix, extract that metric only if the span is not a segment span extracted from a transaction. Long-term, we should stop extracting that transaction metric from spans, and base performance score computation on
"d:spans/webvital.score.total@ratioinstead.