fix(pii): Allow scrubbing of frame.module and culprit #744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer reported that their Electron crashes (with client-side symbolication as it seems) were sending sensitive filepaths in frame.module, which ended up in culprit.
We were completely unable to reproduce this issue (Electron should not send frame.module, and the processing pipeline should not have added the full abs path to the frame.module either), so we're just adding all the remaining fields where this sensitive data ends up.
This also means that Java users can scrub frame.module, which we originally wanted to prevent as it is a footgun that breaks their stacktraces (and, well, we assumed there was no sensitive data in frame.module anyway)
For this specific situation it's likely that culprit does not need to be made scrubbable, as it is filled out based on sensitive data that should be scrubbed otherwise, but in the interest of unblocking the customer for sure, and fixing future similar issues, let's just do it. We already wasted enough time investigating.
The new attributes can be scrubbed with
$frame.module
andculprit
, for example$frame.abs_path || $frame.filename || $frame.module || culprit