Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pii): Allow scrubbing of frame.module and culprit #744

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

untitaker
Copy link
Member

@untitaker untitaker commented Sep 1, 2020

A customer reported that their Electron crashes (with client-side symbolication as it seems) were sending sensitive filepaths in frame.module, which ended up in culprit.

We were completely unable to reproduce this issue (Electron should not send frame.module, and the processing pipeline should not have added the full abs path to the frame.module either), so we're just adding all the remaining fields where this sensitive data ends up.

This also means that Java users can scrub frame.module, which we originally wanted to prevent as it is a footgun that breaks their stacktraces (and, well, we assumed there was no sensitive data in frame.module anyway)

For this specific situation it's likely that culprit does not need to be made scrubbable, as it is filled out based on sensitive data that should be scrubbed otherwise, but in the interest of unblocking the customer for sure, and fixing future similar issues, let's just do it. We already wasted enough time investigating.

The new attributes can be scrubbed with $frame.module and culprit, for example $frame.abs_path || $frame.filename || $frame.module || culprit

@untitaker untitaker requested a review from a team September 1, 2020 14:25
@untitaker untitaker merged commit b78c54a into master Sep 1, 2020
@untitaker untitaker deleted the fix/module-culprit-pii branch September 1, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants