Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pii): Allow scrubbing of frame.module and culprit #744

Merged
merged 2 commits into from
Sep 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Add support for attaching Sentry event payloads in Unreal crash reports by adding `__sentry` game data entries. ([#715](https://github.com/getsentry/relay/pull/715))
- Support chunked formdata keys for event payloads on the Minidump endpoint. Since crashpad has a limit for the length of custom attributes, the sentry event payload can be split up into `sentry__1`, `sentry__2`, etc. ([#721](https://github.com/getsentry/relay/pull/721))
- Add periodic re-authentication with the upstream server, previously there was only one initial authentication. ([#731](https://github.com/getsentry/relay/pull/731))
- The module attribute on stack frames (`$frame.module`) and the (usually serverside-generated) attribute `culprit` can now be scrubbed with advanced data scrubbing. ([#744](https://github.com/getsentry/relay/pull/744))

**Internal**:

Expand Down
2 changes: 1 addition & 1 deletion relay-general/src/protocol/event.rs
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ pub struct Event {
pub fingerprint: Annotated<Fingerprint>,

/// Custom culprit of the event.
#[metastructure(max_chars = "culprit")]
#[metastructure(max_chars = "culprit", pii = "maybe")]
pub culprit: Annotated<String>,

/// Transaction name of the event.
Expand Down
2 changes: 1 addition & 1 deletion relay-general/src/protocol/stacktrace.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ pub struct Frame {
///
/// Note that this might also include a class name if that is something the
/// language natively considers to be part of the stack (for instance in Java).
#[metastructure(skip_serialization = "empty")]
#[metastructure(skip_serialization = "empty", pii = "maybe")]
// TODO: Cap? This can be a FS path or a dotted path
pub module: Annotated<String>,

Expand Down