fix(server): Allow numbers in measurement names #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Sep 28, 2020
dashed
changed the title
dashed
force-pushed
the
allow-numbers-in-measurement-names
branch
from
475050e to
64cc526
Compare
silent1mezzo
approved these changes
Sep 29, 2020
Zylphrex
added a commit
to getsentry/sentry
that referenced
this pull request
Sep 29, 2020
This change makes the measurement columns available to Sentry. Specifically, a measurement x can be queried under the name measurements.x. All measurements are of the type number, and are treated as such. Furthermore, fp, fcp, lcp, and fid are special cased to be treated as durations as well. Measurements can also be used under aggregate functions, provided they are of the appropriate types. This change depends on getsentry/relay/pull/724 and getsentry/relay#785
jan-auer
added a commit
that referenced
this pull request
Oct 5, 2020
* master: fix: use MIN_SRING_LEN in all branches (#791) ci: Simplify GitHub workflows (#790) fix(wstring): Correct out-of-range indexing and is_char_boundary (#787) fix(minidump): Accept big-endian minidumps (#789) release: 0.8.1 fix(server): Allow numbers in measurement names (#785) feat(server): Add support for measurement ingestion (#724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed this in #724 and was discovered in getsentry/sentry#20719
This doesn't break the web vital metrics since their names do not contain numbers.