-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rum): Add ability to query measurements #20719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). |
size-limit report
|
97fc087
to
0f1aa14
Compare
0f1aa14
to
ce9ac25
Compare
7 tasks
ade5a0f
to
c4dd3b4
Compare
dashed
reviewed
Sep 17, 2020
dashed
reviewed
Sep 17, 2020
dashed
reviewed
Sep 17, 2020
b631e49
to
2aa53c1
Compare
98a559d
to
75080e9
Compare
markstory
approved these changes
Sep 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the measurement columns available to Sentry. Specifically, a
measurement
x
can be queried under the namemeasurements.x
.All measurements are of the type number, and are treated as such. Furthermore,
fp
,fcp
,lcp
, andfid
are special cased to be treated as durations aswell.
Measurements can also be used under aggregate functions, provided they are of
the appropriate types.
This change depends on getsentry/relay/pull/724 and getsentry/relay#785