Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rum): Add ability to query measurements #20719

Merged
merged 26 commits into from
Sep 29, 2020

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Sep 10, 2020

This change makes the measurement columns available to Sentry. Specifically, a
measurement x can be queried under the name measurements.x.

All measurements are of the type number, and are treated as such. Furthermore,
fp, fcp, lcp, and fid are special cased to be treated as durations as
well.

Measurements can also be used under aggregate functions, provided they are of
the appropriate types.

This change depends on getsentry/relay/pull/724 and getsentry/relay#785

@vercel
Copy link

vercel bot commented Sep 10, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2020

size-limit report

Path Size
public/app.js 235.47 KB (0%)
public/vendor.js 448.17 KB (0%)

@dashed dashed self-requested a review September 15, 2020 20:58
@dashed dashed force-pushed the feat/ability-to-query-measurements branch from 97fc087 to 0f1aa14 Compare September 15, 2020 23:58
@dashed dashed force-pushed the feat/ability-to-query-measurements branch from 0f1aa14 to ce9ac25 Compare September 16, 2020 21:29
@vercel vercel bot temporarily deployed to Preview September 16, 2020 21:29 Inactive
@vercel vercel bot temporarily deployed to Preview September 16, 2020 21:30 Inactive
@vercel vercel bot had a problem deploying to Preview – storybook September 17, 2020 12:21 Failure
@vercel vercel bot had a problem deploying to Preview – storybook September 17, 2020 14:05 Failure
@vercel vercel bot had a problem deploying to Preview – storybook September 17, 2020 14:31 Failure
@vercel vercel bot had a problem deploying to Preview – storybook September 17, 2020 14:41 Failure
@Zylphrex Zylphrex force-pushed the feat/ability-to-query-measurements branch from ade5a0f to c4dd3b4 Compare September 17, 2020 16:56
@Zylphrex Zylphrex merged commit 87350ca into master Sep 29, 2020
@Zylphrex Zylphrex deleted the feat/ability-to-query-measurements branch September 29, 2020 16:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants