Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replays): add replay event to recording schema #213

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

JoshFerge
Copy link
Member

We're now sending the replay_event to the recording consumer on an optional key. Produced in getsentry/relay#3035, recording consumer change forthcoming

@JoshFerge JoshFerge requested a review from a team as a code owner February 13, 2024 04:16
Copy link

versions in use:

The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.

  • getsentry/sentry: pip:sentry-kafka-schemas==0.1.38 (upgrade)
  • getsentry/relay: rust:sentry-kafka-schemas==0.2.0 (upgrade)

latest version: 0.1.48

changes considered breaking

schemas/ingest-replay-recordings.v1.schema.json

  • {"path": "", "change": {"PropertyAdd": {"lhs_additional_properties": true, "added": "replay_event"}}}
    

⚠️ This PR contains breaking changes. Normally you should avoid that and make
your consumer backwards-compatible (meaning that updated consumers can still
accept old messages). There are a few exceptions:

  • If consumers already require these invariants in practice, and you're
    just adjusting the JSON schema to reality, ignore this warning.

  • If you know what you are doing, this change could potentially be rolled out
    to producers first, but that's not a flow we support.

@JoshFerge
Copy link
Member Author

i'm a a bit confused -- adding an optional field is considered a breaking change?

@lynnagara
Copy link
Member

technically yes if additionalProperties = true, as any type would have been accepted before, and adding the property usually makes it stricter. In this case, since it's bytes and you haven't specified a type, the warning is wrong

@JoshFerge JoshFerge merged commit 819a2ae into main Feb 13, 2024
14 of 15 checks passed
@JoshFerge JoshFerge deleted the jferg/add-replay-event-to-recording branch February 13, 2024 21:55
JoshFerge added a commit to getsentry/sentry that referenced this pull request Feb 23, 2024
…e click issues (#65307)

if the replay event exists, use that instead of querying clickhouse to
create a rage click issue.

related:#65291
#65298
getsentry/relay#3035
getsentry/sentry-kafka-schemas#213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants