-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): use replay_event instead of querying clickhouse for rage click issues #65307
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #65307 +/- ##
===========================================
- Coverage 83.36% 50.72% -32.64%
===========================================
Files 5271 5243 -28
Lines 235726 235016 -710
Branches 40794 40692 -102
===========================================
- Hits 196517 119218 -77299
- Misses 38990 115575 +76585
- Partials 219 223 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the ClickHouse query removed in a different PR?
no, the clickhouse query is not removed yet. it will be removed in a future PR, after all kafka messages have replay_event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify this does not double write. Otherwise looks good.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
if the replay event exists, use that instead of querying clickhouse to create a rage click issue.
related:#65291
#65298
getsentry/relay#3035
getsentry/sentry-kafka-schemas#213