Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): use replay_event instead of querying clickhouse for rage click issues #65307

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

JoshFerge
Copy link
Member

if the replay event exists, use that instead of querying clickhouse to create a rage click issue.

related:#65291
#65298
getsentry/relay#3035
getsentry/sentry-kafka-schemas#213

@JoshFerge JoshFerge requested a review from a team as a code owner February 16, 2024 03:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 50.72%. Comparing base (b399327) to head (5f26f13).

❗ Current head 5f26f13 differs from pull request most recent head 8c40a51. Consider uploading reports for the commit 8c40a51 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #65307       +/-   ##
===========================================
- Coverage   83.36%   50.72%   -32.64%     
===========================================
  Files        5271     5243       -28     
  Lines      235726   235016      -710     
  Branches    40794    40692      -102     
===========================================
- Hits       196517   119218    -77299     
- Misses      38990   115575    +76585     
- Partials      219      223        +4     
Files Coverage Δ
src/sentry/replays/usecases/ingest/dom_index.py 30.18% <25.00%> (-60.26%) ⬇️
...c/sentry/replays/usecases/ingest/issue_creation.py 48.64% <25.00%> (-44.46%) ⬇️

... and 2037 files with indirect coverage changes

Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the ClickHouse query removed in a different PR?

@JoshFerge
Copy link
Member Author

Was the ClickHouse query removed in a different PR?

no, the clickhouse query is not removed yet. it will be removed in a future PR, after all kafka messages have replay_event.

Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify this does not double write. Otherwise looks good.

Base automatically changed from jferg/ref1 to master February 22, 2024 23:27
@JoshFerge JoshFerge merged commit ff12f0e into master Feb 23, 2024
48 checks passed
@JoshFerge JoshFerge deleted the jferg/ref2 branch February 23, 2024 00:33
Copy link

sentry-io bot commented Feb 29, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: timed out sentry.celery in apply_async View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants