Remove excluded_projects & include_all_projects columns #81204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for --
-- Moved alertrule.excluded_projects field to pending deletion state
--
-- (no-op)
--
-- Alter field include_all_projects on alertrule
--
ALTER TABLE "sentry_alertrule" ALTER COLUMN "include_all_projects" DROP NOT NULL;
--
-- Moved alertrule.include_all_projects field to pending deletion state
--
-- (no-op) |
markstory
approved these changes
Nov 22, 2024
Yep, I'll be removing that and |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81204 +/- ##
=======================================
Coverage 80.34% 80.34%
=======================================
Files 7216 7218 +2
Lines 319481 319524 +43
Branches 20779 20779
=======================================
+ Hits 256679 256725 +46
+ Misses 62408 62405 -3
Partials 394 394 |
ceorourke
force-pushed
the
ceorourke/rm-include-exclude-projects
branch
from
281811b to
481441f
Compare
wedamija
reviewed
Nov 22, 2024
Comment on lines
+40
to
+44
| SafeRemoveField( | ||
| model_name="alertrule", | ||
| name="excluded_projects", | ||
| deletion_action=DeletionAction.MOVE_TO_PENDING, | ||
| ), |
wedamija
approved these changes
Nov 22, 2024
evanh
pushed a commit
that referenced
this pull request
Nov 25, 2024
In preparation for removing the `AlertRuleExcludedProjects` model (see #81020) we need to first remove the many to many `excluded_projects` column on the `AlertRule` model. We can take the opportunity to remove the now unused `include_all_projects` column. This PR uses the brand new `SafeRemoveField` option added in #81098
ceorourke
added a commit
that referenced
this pull request
Nov 25, 2024
Follow up to #81204 to fully remove `excluded_projects` and `include_all_projects` from the `AlertRule` model which was blocking removing the `AlertRuleExcludedProjects` table.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
In preparation for removing the `AlertRuleExcludedProjects` model (see #81020) we need to first remove the many to many `excluded_projects` column on the `AlertRule` model. We can take the opportunity to remove the now unused `include_all_projects` column. This PR uses the brand new `SafeRemoveField` option added in #81098
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Follow up to #81204 to fully remove `excluded_projects` and `include_all_projects` from the `AlertRule` model which was blocking removing the `AlertRuleExcludedProjects` table.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for removing the
AlertRuleExcludedProjectsmodel (see #81020) we need to first remove the many to manyexcluded_projectscolumn on theAlertRulemodel. We can take the opportunity to remove the now unusedinclude_all_projectscolumn. This PR uses the brand newSafeRemoveFieldoption added in #81098