Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(alerts): Drop included and excluded projects #81250

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

ceorourke
Copy link
Member

Follow up to #81204 to fully remove excluded_projects and include_all_projects from the AlertRule model which was blocking removing the AlertRuleExcludedProjects table.

@ceorourke ceorourke requested a review from a team as a code owner November 25, 2024 17:38
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 25, 2024
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0795_drop_included_excluded_projects.py ()

--
-- Remove field excluded_projects from alertrule
--
-- (no-op)
--
-- Remove field include_all_projects from alertrule
--
ALTER TABLE "sentry_alertrule" DROP COLUMN "include_all_projects" CASCADE;

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just make sure the previous pr has deployed before merging

@ceorourke ceorourke merged commit 98db829 into master Nov 25, 2024
51 checks passed
@ceorourke ceorourke deleted the ceorourke/rm-include-exclude-projects-fully branch November 25, 2024 19:35
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
Follow up to #81204 to fully
remove `excluded_projects` and `include_all_projects` from the
`AlertRule` model which was blocking removing the
`AlertRuleExcludedProjects` table.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants