Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.4] Fix STORAGE_READ support #458

Closed
kvark opened this issue Jan 15, 2020 · 1 comment
Closed

[0.4] Fix STORAGE_READ support #458

kvark opened this issue Jan 15, 2020 · 1 comment
Labels
good first issue Good for newcomers help required We need community help to make this happen. type: bug Something isn't working

Comments

@kvark
Copy link
Member

kvark commented Jan 15, 2020

We aren't mapping it properly to gfx:

wgpu/wgpu-native/src/conv.rs

Line 38 in b7182e6

if usage.contains(W::STORAGE) {

This is fixed in master, but we need a patch for the released version.
@kvark kvark added type: bug Something isn't working help required We need community help to make this happen. good first issue Good for newcomers labels Jan 15, 2020
This was referenced Jan 15, 2020
Closed
Merged
Closed
bors bot added a commit that referenced this issue Jan 21, 2020
@bors @kvark @Korijn
Merge #465
55aab54 
465: [0.4] Refactor the swap chain frame tracking r=kvark a=kvark

On the surface, it gets us from "key not present" to "Used swap chain frame has already presented" in the case of an application presenting before submitting a command buffer. But the worst thing is that we used to lock up the driver on that presentation, so now the problem is much less mysterious.
cc @snuk182 

Fixes #458
Works around #227 

Co-authored-by: Dzmitry Malyshau <[email protected]>
Co-authored-by: Korijn van Golen <[email protected]>
@kvark
Copy link
Member Author

kvark commented Jan 21, 2020

Fixed by #465, published in wgpu-native-0.4.3

@kvark kvark closed this as completed Jan 21, 2020
kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
@bors @Andful
[rs] Merge gfx-rs#466
3e8ab74 
466: add debug trait for public types r=kvark a=Andful

This pull request is to resolve the issue gfx-rs#458.
This pull request is still incomplete. The only problematic trait is `RenderBundleEncoder`.
For the native version, `RenderBundleEncoder` does not implement `Debug`. This would have to be implemented in the wgpu project.
 FYI, Context does not need to implement `Debug`. The type that implements `Context` is used directly, i.e. `Arc<C>` is used and not `Arc<dyn Context>`


Co-authored-by: Andrea Nardi <[email protected]>
kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
@bors @Andful
[rs] Merge gfx-rs#475
53fa510 
475: Made RenderBundleEncoder derive Debug r=kvark a=Andful

This is a continuation of the pull request gfx-rs#466 and should resolve the issue gfx-rs#458.

Co-authored-by: Andrea Nardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help required We need community help to make this happen. type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvark