Return custom AdapterInfo that contains backend.
#475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
requested changes
Jan 26, 2020
|
Done. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 28, 2020
475: Return custom `AdapterInfo` that contains backend. r=kvark a=daxpedda When requesting an `Adapter` in combination with `BackendBit::all()`, there was no way to determine what backend was ultimately chosen. This change implements a custom `AdapterInfo` that contains a field with `Backend`, it does otherwise not differ from `gfx_hal::adapter::AdapterInfo`. The only question I have is about `serde` implementation, currently I can't derive de/serialization from it because of `DeviceType`. This could be fixed by activating the `serde` feature in `gfx-hal`, which isn't possible (as far as i know) without renaming our current `serde` feature. Co-authored-by: daxpedda <[email protected]>
Build succeeded |
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
475: Made RenderBundleEncoder derive Debug r=kvark a=Andful This is a continuation of the pull request gfx-rs#466 and should resolve the issue gfx-rs#458. Co-authored-by: Andrea Nardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting an
Adapterin combination withBackendBit::all(), there was no way to determine what backend was ultimately chosen.This change implements a custom
AdapterInfothat contains a field withBackend, it does otherwise not differ fromgfx_hal::adapter::AdapterInfo.The only question I have is about
serdeimplementation, currently I can't derive de/serialization from it because ofDeviceType. This could be fixed by activating theserdefeature ingfx-hal, which isn't possible (as far as i know) without renaming our currentserdefeature.