Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git output misalligned #648

Closed
Southporter opened this issue Oct 10, 2023 · 1 comment · Fixed by #649
Closed

Git output misalligned #648

Southporter opened this issue Oct 10, 2023 · 1 comment · Fixed by #649

Comments

@Southporter
Copy link
Collaborator

Screenshot 2023-10-09 at 4 07 09 PM

Somehow, the terminal is getting out of sync.

Details

CPU/OS: M1, M2 MacOS and x86_64 linux
Shell: Fish

Repro Steps

mkdir test && cd test
git init
npm i -D typescript
npx tsc -w
// If that doesn't work, use the attached package.json and run
npm run watch

Then quit the watch with Ctrl-C.

From then on, git status will display incorrectly aligned.
Running reset fixes the issue.
After running reset the same steps will NOT reproduce the issue.
From what I can tell, needs a fresh tab or window to trigger.

Resources

package.json
@mitchellh
Copy link
Contributor

Reproduced it, thanks looking into it

mitchellh added a commit that referenced this issue Oct 10, 2023
@mitchellh
terminal: RIS should reset tabstops, ESC ? W should reset every 8
7874a30 
Fixes #648

Two issues here:

  - RIS should've been resetting the tabstops to every 8, but was
    clearing all tabstops.

  - `ESC ? W` should've reset tabstops to every 8, but was clearing
    all tabstops.
@mitchellh mitchellh mentioned this issue Oct 10, 2023
Merged
mitchellh added a commit that referenced this issue Oct 10, 2023
@mitchellh
terminal: RIS should reset tabstops, ESC ? W should reset every 8
fa92301 
Fixes #648

Two issues here:

  - RIS should've been resetting the tabstops to every 8, but was
    clearing all tabstops.

  - `ESC ? W` should've reset tabstops to every 8, but was clearing
    all tabstops.
mitchellh added a commit that referenced this issue Oct 10, 2023
@mitchellh
terminal: RIS should reset tabstops, ESC ? W should reset every 8
f216609 
Fixes #648

Two issues here:

  - RIS should've been resetting the tabstops to every 8, but was
    clearing all tabstops.

  - `ESC ? W` should've reset tabstops to every 8, but was clearing
    all tabstops.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

terminal: RIS should reset tabstops, ESC ? W should reset every 8 ghostty-org/ghostty
2 participants
@mitchellh @Southporter