terminal: RIS should reset tabstops, ESC ? W should reset every 8 #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #648 Two issues here: - RIS should've been resetting the tabstops to every 8, but was clearing all tabstops. - `ESC ? W` should've reset tabstops to every 8, but was clearing all tabstops.
|
Note: I didn't add new unit tests for this because both of the affected sequences will get full unit test coverage soon as part of #632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #648
Two issues here:
RIS should've been resetting the tabstops to every 8, but was
clearing all tabstops.
ESC ? Wshould've reset tabstops to every 8, but was clearingall tabstops.