Add support for OCaml 5.00 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/ounit
that referenced
this pull request
Jun 28, 2022
In gildor478#92 @kit-ty-kate added support for the `Seq` API instead of the Stream API to be compatible with OCaml 5, which is very convenient, as we are approaching a release. While attempting to port the `gettext` unit tests which use `assert_command` I ran into the issue that migrating the tests to the `Seq` API was simple but they were always failing with an `End_of_file` exception. Upon further inspection I realized the issue must be in ounit, and indeed: the previous code used `Stream.of_channel` which presumably handled `End_of_file` while the new `Seq` API would build an infinite `Seq`, attempting to read from the end of a channel, even if it was already at the end. This changes the code to implement a functionality similar to `Stream.of_channel`. Attempting to run the `gettext` unit tests succeeds without issues with this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.