Handle end of channel in Seq API
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In gildor478#92 @kit-ty-kate added support for the `Seq` API instead of the Stream API to be compatible with OCaml 5, which is very convenient, as we are approaching a release. While attempting to port the `gettext` unit tests which use `assert_command` I ran into the issue that migrating the tests to the `Seq` API was simple but they were always failing with an `End_of_file` exception. Upon further inspection I realized the issue must be in ounit, and indeed: the previous code used `Stream.of_channel` which presumably handled `End_of_file` while the new `Seq` API would build an infinite `Seq`, attempting to read from the end of a channel, even if it was already at the end. This changes the code to implement a functionality similar to `Stream.of_channel`. Attempting to run the `gettext` unit tests succeeds without issues with this patch.
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/ocaml-gettext
that referenced
this pull request
Jun 28, 2022
This patch requires a release of ounit that incorporates the fix in gildor478/ounit#95 for the `Seq` API to correctly handle the end of the channel.
|
Hi @gildor478, do you have a moment to look into this? I am trying to unblock as many packages as possible for compatibility with OCaml 5.0 and getting gettext working via this PR would potentially allow an additional 1728 packages to build on OCaml 5.0. |
It's not really true. It's only counted high in the revdeps count because it was once a dependency of OASIS. But not anymore. Apart from older versions of OASIS no packages are really using |
|
Well fair enough, however fixing the issue won't hurt in any case.
|
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/ocaml-gettext
that referenced
this pull request
Dec 2, 2022
This patch requires a release of ounit that incorporates the fix in gildor478/ounit#95 for the `Seq` API to correctly handle the end of the channel.
MisterDA
added a commit
to MisterDA/opam-repository
that referenced
this pull request
Mar 22, 2023
CHANGES: ### Fixed - Handle end of channel in Seq API. gildor478/ounit#95, @Leonidas-from-XIV - Windows and OCaml 5 compatibility. gildor478/ounit#96, @MisterDA ### Changed - Update to Dune 3.0 for newer stanzas and warnings. gildor478/ounit#96, @MisterDA
gildor478
pushed a commit
to gildor478/ocaml-gettext
that referenced
this pull request
Dec 26, 2024
This patch requires a release of ounit that incorporates the fix in gildor478/ounit#95 for the `Seq` API to correctly handle the end of the channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #92 @kit-ty-kate added support for the
SeqAPI instead of theStreamAPI to be compatible with OCaml 5, which is very convenient, as we are approaching a release soonWhile attempting to port the
gettextunit tests which useassert_commandI ran into the issue that migrating the tests to theSeqAPI was simple but they were always failing with anEnd_of_fileexception.Upon further inspection I realized the issue must be in ounit, and indeed: the previous code used
Stream.of_channelwhich presumably handledEnd_of_filewhile the newSeqAPI would build an infiniteSeq, attempting to read from the end of a channel, even if it was already at the end.This changes the code to implement a functionality similar to
Stream.of_channel.Attempting to run the
gettextunit tests succeeds without issues with this patch.