-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Pipfile without Pipfile.lock #1026
Conversation
Thanks @kojiromike 👍 I rewrote it a bit. I looked at adding a test for this, but the current test setup is a bit too inflexible 😬 (but I did test locally) |
Thanks @RasmusWL! Please let me know if there's anything else I can do to help. |
@RasmusWL sorry to bug you, but should I continue to keep the branch updated, or just wait for someone from codeql-action-reviewers to get back to this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix!
As previously written, if codeql finds a `Pipfile`, but no `Pipfile.lock`, it will run `pipenv install` with args that require `Pipfile.lock` to exist. Pipfile will fail with this message: ``` Usage: python -m pipenv install [OPTIONS] [PACKAGES]... ERROR:: Pipfile.lock must exist to use --keep-outdated! package installation with pipenv failed, see error above ``` This changeset enables auto_install to work with Pipfile when there is no lock. (Bonus: `--skip-lock` is generally a bit faster.)
Thanks for your work on this, and your continued effort to keep the branch up to date. I would have not have expected you to put in this effort. Once someone from |
As previously written, if codeql finds a
Pipfile
, but noPipfile.lock
, it will runpipenv install
with args that requirePipfile.lock
to exist. Pipfile will fail with this message:This changeset enables auto_install to work with Pipfile when there is no lock. (Bonus:
--skip-lock
is generally a bit faster.)Merge / deployment checklist