Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Pipfile without Pipfile.lock #1026

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Support Pipfile without Pipfile.lock #1026

merged 2 commits into from
Apr 18, 2022

Commits on Apr 18, 2022

  1. Support Pipfile without Pipfile.lock 

    As previously written, if codeql finds a `Pipfile`, but no `Pipfile.lock`, it will run `pipenv install` with args that require `Pipfile.lock` to exist. Pipfile will fail with this message:

```
  Usage: python -m pipenv install [OPTIONS] [PACKAGES]...
  
  ERROR:: Pipfile.lock must exist to use --keep-outdated!
  package installation with pipenv failed, see error above
```

This changeset enables auto_install to work with Pipfile when there is no lock. (Bonus: `--skip-lock` is generally a bit faster.)
    @kojiromike
    kojiromike committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    808c292 View commit details
    Browse the repository at this point in the history

  2. python-setup: refactor Pipenv without lockfile

    @RasmusWL @kojiromike
    RasmusWL authored and kojiromike committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    b9577df View commit details
    Browse the repository at this point in the history