Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait for processing in test mode #1050

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

henrymercer
Copy link
Contributor

In test mode, we don't upload results, so there's no point waiting for processing. Disabling waiting for processing when we're in test mode speeds up most of our PR checks and removes Actions warnings from waiting for processing failing because we didn't upload any SARIF.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner April 28, 2022 18:12
In test mode, we don't upload results, so there's no point waiting for
processing.
@henrymercer henrymercer force-pushed the henrymercer/dont-wait-for-processing-in-test-mode branch from 15f411d to ea676e3 Compare April 28, 2022 18:14
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants