-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge releases/v2 into releases/v1 #1071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mergeback v2.1.9 refs/heads/releases/v2 into main
…ades Prompt customers to upgrade from v1 to v2
In test mode, we don't upload results, so there's no point waiting for processing.
Also, this cleans up our pack-related integration tests. We are now testing with the most recent CLIs.
…sing-in-test-mode Don't wait for processing in test mode
This will allow the command to resolve packs with paths. Also, use a more concise version of `tr`.
Allow running packs with paths
Clarify instructions for updating required checks
Update CONTRIBUTING.md
Update contributing guide. Ensure this workflow runs once a week.
Add workflow to regenerate required checks
Add permissions to workflow
…n failing the workflow run.
Fix processing errors being caught and logged as a warning rather than failing the workflow run.
Update codeql to 2.9.1
This also removes the .github/workflows/update-required-checks.yml workflow. This script needs to be run locally by someone who has admin privileges on the repo.
Create update-required-checks script
Merge main into releases/v2
We only need to run `git commit` after the `git merge` call if there were conflicts.
…mmit Remove an extraneous commit during the release process
The GitHub API client coerces `fake-server-url` to the Dotcom API URL, which means commands like `util.getGitHubVersion` will call the Dotcom API with the `fake-token`, resulting in 401s. We therefore use the Dotcom URL instead and additionally stub `util.getGitHubVersion` as a good practice (it's no longer necessary).
…s-on-v1 Fix integration tests on v1
This reverts commit e34f3ea.
This reverts commit e3983ef.
github-actions
bot
added
the
Update dependencies
Trigger PR workflow to update dependencies
label
May 11, 2022
github-actions
bot
removed
the
Update dependencies
Trigger PR workflow to update dependencies
label
May 11, 2022
henrymercer
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging 2f58583 into releases/v1
Conductor for this PR is @henrymercer
Contains the following pull requests:
Please review the following: