Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge releases/v2 into releases/v1 #1071

Merged
merged 41 commits into from
May 11, 2022
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 11, 2022

Merging 2f58583 into releases/v1

Conductor for this PR is @henrymercer

Contains the following pull requests:

Please review the following:

  • The CHANGELOG displays the correct version and date.
  • The CHANGELOG includes all relevant, user-facing changes since the last release.
  • There are no unexpected commits being merged into the releases/v1 branch.
  • The docs team is aware of any documentation changes that need to be released.

henrymercer and others added 30 commits April 27, 2022 16:11
Mergeback v2.1.9 refs/heads/releases/v2 into main
…ades

Prompt customers to upgrade from v1 to v2
In test mode, we don't upload results, so there's no point waiting for
processing.
Also, this cleans up our pack-related integration tests.
We are now testing with the most recent CLIs.
…sing-in-test-mode

Don't wait for processing in test mode
This will allow the command to resolve packs with paths.

Also, use a more concise version of `tr`.
Clarify instructions for updating required checks
Update contributing guide.
Ensure this workflow runs once a week.
Add workflow to regenerate required checks
Fix processing errors being caught and logged as a warning rather than failing the workflow run.
This also removes the .github/workflows/update-required-checks.yml
workflow. This script needs to be run locally by someone who has
admin privileges on the repo.
github-actions[bot] and others added 10 commits May 10, 2022 11:33
We only need to run `git commit` after the `git merge` call if there were conflicts.
…mmit

Remove an extraneous commit during the release process
The GitHub API client coerces `fake-server-url` to the Dotcom API URL,
which means commands like `util.getGitHubVersion` will call the Dotcom
API with the `fake-token`, resulting in 401s.

We therefore use the Dotcom URL instead and additionally stub
`util.getGitHubVersion` as a good practice (it's no longer necessary).
@github-actions github-actions bot added the Update dependencies Trigger PR workflow to update dependencies label May 11, 2022
@edoardopirovano edoardopirovano marked this pull request as ready for review May 11, 2022 15:55
@edoardopirovano edoardopirovano requested a review from a team as a code owner May 11, 2022 15:55
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label May 11, 2022
@henrymercer henrymercer merged commit 5e59d8e into releases/v1 May 11, 2022
@henrymercer henrymercer deleted the update-v1.1.10-2f58583a branch May 11, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants