Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LABELS_TO_MEASURE causes the action to fail #180

Closed
cmayor opened this issue Dec 14, 2023 · 4 comments · Fixed by #182
Closed

LABELS_TO_MEASURE causes the action to fail #180

cmayor opened this issue Dec 14, 2023 · 4 comments · Fixed by #182
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@cmayor
Copy link

cmayor commented Dec 14, 2023

If LABELS_TO_MEASURE is set then the action will fail with:

Starting issue-metrics search...
  File "/action/workspace/issue_metrics.py", line 331, in <module>
    main()
  File "/action/workspace/issue_metrics.py", line 262, in main
    labels = labels.split(",")
             ^^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'split'

It looks like the block here is redundant after this PR which already converts the environment string to a list.

@zkoppert
Copy link
Member

Thanks for submitting this issue! I'm currently on holiday so I'll take a look at this when I return in January.

@zkoppert zkoppert added bug Something isn't working good first issue Good for newcomers labels Dec 16, 2023
@parkerbxyz parkerbxyz mentioned this issue Dec 20, 2023
4 tasks
@hianhianhian
Copy link

Hi, I'm currently blocked by this issue so I figured I could just use an older version of the action (e.g. v2.14.0), so I changed my workflow yml file as follows

- name: Run issue-metrics tool
   uses: github/[email protected]

However, I still run into this issue. It seems that even if I use an older version of the action, it's still pulling the latest Docker image ie.

image: 'docker://ghcr.io/github/issue_metrics:v2'

I'm not too familiar with Docker, but was just wondering if anything can be done to workaround this?

@FujiKinaga
Copy link

@zkoppert
Hello!
When will this PR be available with a tag?
We will want to incorporate this feature as soon as possible...
Because we are haunted by #180 (comment).

@zkoppert
Copy link
Member

@FujiKinaga Thanks for the reminder to get this released! I have released it today: https://github.com/github/issue-metrics/releases/tag/v2.14.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants