Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I found some logic in
issue_metrics.py
that is duplicating environment variable processing already happening viaget_env_vars()
inconfig.py
, which was introduced in #171.issue-metrics/config.py
Lines 61 to 71 in ebc6a99
Duplicate logic:
issue-metrics/issue_metrics.py
Lines 260 to 264 in ebc6a99
issue-metrics/issue_metrics.py
Lines 140 to 141 in ebc6a99
Removing this duplicate logic fixes #180.
Readiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducingReviewer
bug
,documentation
,enhancement
,infrastructure
, orbreaking