-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update README (take over #131) #139
Conversation
Co-authored-by: MihirKohli <[email protected]>
It seems there are still some points that need correction. After making the changes, I will undraft the PR. |
it looks like a few of the docs like the json output, measuring time and others in the docs directory aren't all referenced in the README. I think each doc should at least get a mention in the readme. |
Thank you for the wonderful review!! Regarding "I think each doc should at least get a mention in the readme.", are you suggesting adding a section with links to each item as in the following example? ## links
- [Assigning teams instead of individuals](./docs/assign-team-instead-of-individual.md)
- ... |
Yes that would be great. |
Thank you for the wonderful review!! I made three changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you so much @Okabe-Junya for leading this to completion!! Really appreciate all your contributions to this project! 🎉 🚀
take over #131
Proposed Changes
I have structured the README. Only the essential information is retained in the README, and I've made changes to store each document in the
docs
directory. This is based on the structure of the CodeQL repository.(If there are any rules or standards we must adhere to within the GitHub organization, I would like to make further adjustments to comply with them.)
Readiness Checklist
In addition, I made the following changes:
docs
directory. Managing permalinks can be cumbersome, so I believe it's best to remove them.Author/Contributor
Note: In this PR, since only documentation updates are being made, I don't anticipate any linting or testing issues to arise.
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducingReviewer
bug
,documentation
,enhancement
,infrastructure
, orbreaking