Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README collisions #140

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Fix README collisions #140

merged 3 commits into from
Oct 13, 2023

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Oct 12, 2023 •
edited
Loading

This fixes:

          @zkoppert looks like merging this has accidentally done some of the changes that we did in https://github.com/github/issue-metrics/pull/137 prior to this.

Originally posted by @spier in #139 (comment)

Proposed Changes

  • Fix overwrite of pr's that were merged in at a similar time.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@zkoppert zkoppert self-assigned this Oct 12, 2023
@zkoppert zkoppert mentioned this pull request Oct 12, 2023
Merged
4 tasks
@zkoppert zkoppert added the documentation Improvements or additions to documentation label Oct 12, 2023
@zkoppert
Copy link
Member Author

Let me know if I missed something @spier. I looked here to see what got overwritten: https://github.com/github/issue-metrics/pull/137/files

@zkoppert zkoppert marked this pull request as ready for review October 12, 2023 23:22
spier
spier reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Left one comment thought.

README.md Outdated Show resolved Hide resolved
@zkoppert @spier
Make config description concise
e8b46d3 
Co-authored-by: Sebastian Spier <[email protected]>
@zkoppert zkoppert merged commit e63dc5a into main Oct 13, 2023
4 checks passed
@zkoppert zkoppert deleted the fix-pr-collision branch October 13, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spier spier spier left review comments

Assignees

@zkoppert zkoppert

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkoppert @spier