Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate logic #182

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Remove duplicate logic #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4e91db
Remove duplicate string split logic for labels
parkerbxyz Dec 20, 2023
f82d81b
Remove duplicate string split logic for ignore_users
parkerbxyz Dec 20, 2023
fc015f3
install make so that we can do builds
zkoppert Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ COPY requirements.txt *.py /action/workspace/
RUN python3 -m pip install --no-cache-dir -r requirements.txt \
&& apt-get -y update \
&& apt-get -y install --no-install-recommends git-all=1:2.39.2-1.1 \
&& apt-get install build-essential -y --no-install-recommends \
&& rm -rf /var/lib/apt/lists/*

CMD ["/action/workspace/issue_metrics.py"]
Expand Down
6 changes: 0 additions & 6 deletions issue_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,6 @@ def get_per_issue_metrics(
issues_with_metrics = []
num_issues_open = 0
num_issues_closed = 0
if ignore_users is None:
ignore_users = []

for issue in issues:
if discussions:
Expand Down Expand Up @@ -258,10 +256,6 @@ def main():

# Determine if there are label to measure
labels = env_vars.labels_to_measure
if labels:
labels = labels.split(",")
else:
labels = []

# Search for issues
# If type:discussions is in the search_query, search for discussions using get_discussions()
Expand Down