Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue counts incorrect when HIDE_TIME_TO_CLOSE is True #311

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Jun 10, 2024

Pull Request

Fixes #310

Proposed Changes

This pull request improves the get_per_issue_metrics function in issue_metrics.py by ...

  • Expanding the test coverage in test_issue_metrics.py to cover counting logic when env vars are set
  • Changing the issue counting logic so it is not gated by the HIDE_TIME_TO_CLOSE env var

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

issue_metrics.py Outdated Show resolved Hide resolved
issue_metrics.py Outdated Show resolved Hide resolved
zkoppert and others added 2 commits June 11, 2024 08:59
Signed-off-by: Zack Koppert <[email protected]>
@zkoppert zkoppert merged commit 418d42b into main Jun 12, 2024
26 checks passed
@zkoppert zkoppert deleted the fix_issue_count branch June 12, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Items closed/opened counts are incorrect when HIDE_TIME_TO_CLOSE is True
3 participants